Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make class selector dynamic #104

Open
stiber opened this issue Oct 7, 2021 · 3 comments · May be fixed by #111
Open

Make class selector dynamic #104

stiber opened this issue Oct 7, 2021 · 3 comments · May be fixed by #111
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stiber
Copy link
Contributor

stiber commented Oct 7, 2021

Right now, InputConfigClassSelectionDialog has hard-coded classes; instead, it should load that information from AllParamsClasses.xml
@stiber stiber added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2021
@pali-r
Copy link

pali-r commented Oct 8, 2021

Is this issue open to be assigned to someone? If yes, can I work on this?

@stiber
Copy link
Contributor Author

stiber commented Oct 10, 2021

Yes, after some consulting with our team, you are welcome to work on this. Feel free to fork the repo; when you create the pull request, it would be great if you could introduce yourself. You can request that @king-shak review your pull request. Please refer to our GitHub wiki pages for information about our project, including style guide and tools.

We haven't yet automated style and build checks (or written a CONTRIBUTING.md), though that will be coming in the not-too-distant future. Meanwhile, please be sure to check that your code builds and run checkstyle to make sure it passes our style requirements.

@pali-r
Copy link

pali-r commented Oct 11, 2021

Ok, thank you. I will start working on it.

@pali-r pali-r linked a pull request Nov 9, 2021 that will close this issue
Open
@stiber stiber linked a pull request Nov 9, 2021 that will close this issue
make class selector dynamic #111
Open
@stiber stiber removed a link to a pull request Jan 8, 2022
make class selector dynamic #111
Open
@stiber stiber linked a pull request Jan 8, 2022 that will close this issue
make class selector dynamic #111
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make class selector dynamic pali-r/WorkBench
2 participants
@stiber @pali-r