Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HRSC SRC images #3665

Closed
Ethands123 opened this issue Jan 31, 2020 · 9 comments
Closed

Add support for HRSC SRC images #3665

Ethands123 opened this issue Jan 31, 2020 · 9 comments
Labels
enhancement New feature or request Products Issues which are impacting the products group

Comments

@Ethands123
Copy link

ISIS version(s) affected: x.y.z
Using isis3.9.1
Description

When running spiceinit on a HRSC SRC image I get an error.
Spice_error

How to reproduce

To reproduce the data is at /work/users/edsmith/Phobos/HRCS the SRC image is
HI837_0002_SR2.IMG
HI837_0002_SR2.cub
I took the .IMG file ran it through pds2isis then attempted spiceinit with the resulting .cub file.
In the same area is a HRSC image from not the SRC I grabbed a nadir image seen below and I was able to ingest this with hrsc2isis and then spiceinit was successful.
HI395_0000_ND2.IMG
HI395_0000_ND2.cub
Possible Solution

Additional context

I grabbed the images from https://archives.esac.esa.int/psa/#!Table%20View/Phobos=target

@Ethands123 Ethands123 changed the title HRSC SRC Images Getting Error At Spiceinit HRSC SRC Images Error At Spiceinit Jan 31, 2020
@krlberry
Copy link
Contributor

krlberry commented Feb 1, 2020

Hi @Ethands123, As a quick initial response, pds2isis unfortunately doesn't provide the cube it outputs with all the information needed for spiceinit to run. hrsc2isis would normally add this information to the cube, but I see that it doesn't support SRC data. I don't have much experience with HRSC specifically, so maybe another developer could chime in with more information, but it looks to me like to fix this problem, hrsc2isis (and maybe the camera model) would need to be updated to support SRC data.

@blandoplanet blandoplanet added the Products Issues which are impacting the products group label Feb 3, 2020
@blandoplanet
Copy link

This may be a blocker for the Phobos IAA task. I'll iterate with the PC.

@jessemapel
Copy link
Contributor

@Ethands123 Did hrsc2isis fail on this image? The HRSC camera model requires some specific information that gets parsed during hrsc2isis, so spiceinit failing after using pds2isis to ingest HRSC data is expected.

@Ethands123
Copy link
Author

@jessemapel hrsc2isis gives the error seen below which tells me to use pds2isis.
image

@kberryUSGS Thanks for checking it out so fast.

@jessemapel jessemapel added the enhancement New feature or request label Feb 3, 2020
@jessemapel jessemapel changed the title HRSC SRC Images Error At Spiceinit Add support for HRSC SRC images Feb 3, 2020
@jessemapel
Copy link
Contributor

I'm labeling this as an enhancement because the sensor and ingestion are not designed to support SRC images

@lwellerastro
Copy link
Contributor

lwellerastro commented Feb 5, 2020

@Ethands123, I just looked at the documentation for hrsc2isis
https://isis.astrogeology.usgs.gov/Application/presentation/Tabbed/hrsc2isis/hrsc2isis.html and that example uses data having the format RE2.IMG as opposed to SR2.IMG or ND2.IMG. I think the R means it is radiometrically corrected.

I found an abstract by Kirk et. al. https://elib.dlr.de/93867/1/2535.pdf involving this data and they said they used already calibrated images. But it also looks like they were under ISIS2. I'm assuming we converted that version of the program to ISIS3 but I honestly don't know.

Would you mind looking in the archive you pulled from and see if there are RE2 versions of the images you are interested in and running those through hrsc2isis. I don't know how the archive is set up, so the files may be under another directory and they may refer to it as "Level 2" which used by the PDS to indicate it was specially processed (and is not the same as Level 2 in ISIS which means map projected - I know, totally confusing!). Let us know how that goes.

It's also possible this is not data they bothered to clean up (I'm forgetting we're talking about Phobos and not Mars), so you might have grabbed the only data available.

@jlaura
Copy link
Collaborator

jlaura commented May 26, 2020

@scsides Can we close this after the HRSC SRC sensor model work?

@scsides
Copy link
Contributor

scsides commented May 27, 2020 via email

@jessemapel
Copy link
Contributor

Closing as this was reported as done. If this is not complete then please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Products Issues which are impacting the products group
Projects
None yet
Development

No branches or pull requests

7 participants