New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_ferroalloy_proxy.py #47

Open

burnettear opened this issue Jan 23, 2025 · 1 comment

Assignees

Collaborator

burnettear commented Jan 23, 2025

Code review of file task_ferroalloy_proxy.py

Good:

Input and output data files are present at specified filepaths
Units and formatting of output data is compliant
Header comment has added and made compliant
Comments explain data operations

Improvements:

Header added to be compliant
Comments added to code chunks
Extended documentation changed from comment out to inline comments
Code was not run/tested

TODO:

@nkruskamp See TODO comments here in the code review branch.
Review updated comments and documentation, and approve.

burnettear assigned nkruskamp

Collaborator Author

burnettear commented Jan 27, 2025

https://github.com/USEPA/GEPA/blob/code_review_2024-12/gch4i/proxy_processing/task_ferroalloy_proxy.py

Corrected Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment