Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in NLCD40 Land Use Mapping for Inline Windblown Dust Calculations #220

Closed
chogrefe opened this issue Oct 11, 2024 · 3 comments
Closed

Comments

@chogrefe
Copy link
Contributor

chogrefe commented Oct 11, 2024

Description
The current inline windblown dust (WBD) code can cause excessive WBD emissions when using WRF simulations with NLCD40 land use (LU). The excessive emissions are caused by mapping two NLCD40 categories (“shrub/scrub” and “dwarf scrub”) to the wrong internal BELD3 LU class (“barren or sparsely vegetated” instead of “shrubland”) that is being used in the WBD module to assign parameter values controlling erodibility.

Scope and Impact
When enabling the inline WBD module and using WRF simulations with NLCD40 LU as input, 2018 annual domain total WBD emissions over the 12US1 domain were reduced by about factor of 3-4 after correcting the erroneous LU mapping with the code fix described below, with the exact reduction depending on the approach to specify vegetation fraction in the WRF simulations and likely also depending on the domain and year being simulated.

Additional context
Users wishing to correct the erroneous NLCD40 mapping prior to a future release in the v55+ branch should make the following modification to file lus_data_module.F:

In lines 310 - 311, change

  &              3,       ! barrenland
  &              3,       ! barrenland

to

  &              1,       ! shrubland
  &              1,       ! shrubland

so that the entire NLCD40 to BELD3 mapping block looks as follows:

        integer :: dmap_nlcd40( n_dlcat_nlcd40+1 ) = ! land use type desert map to BELD3
 &           (/ 1,       ! shrubland
 &              1,       ! shrubland
 &              3,       ! barrenland
 &              1,       ! shrubland
 &              1,       ! shrubland
 &              3,       ! barrenland
 &              3 /)     ! ag landuse surrogate
@carb-jlu
Copy link

Then, should the values at line 302 and 303 be updated too?

@chogrefe
Copy link
Contributor Author

Then, should the values at line 302 and 303 be updated too?

Good question. No, these lines do not have to be updated because the dmsk_nlcd40 array (mapped to dmsk in centralized_io_module.F) is a vestige from earlier code versions that is no longer used in any WBD calculations. Therefore, the LU-specific dmsk_* arrays in lus_data_module.F and their mapping to dmsk in centralized_io_module.F should arguably be removed in future code updates, but in the meantime, the erroneous mapping defined in these arrays will not affect any calculations and does not require any update (though it could be updated for aesthetic reasons).

@kmfoley
Copy link
Collaborator

kmfoley commented Dec 7, 2024

Resolved with PR #222.

@kmfoley kmfoley closed this as completed Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants