From 5c1cfbf0ea740f1142038972d5323d644ff2a95c Mon Sep 17 00:00:00 2001 From: Onitoxan Date: Wed, 27 Nov 2024 15:03:16 +0100 Subject: [PATCH] Add initial pending review test --- apps/hpc-ftsadmin-e2e/src/support/commands.ts | 1 + apps/hpc-ftsadmin-e2e/src/tests/pending-flow.cy.ts | 14 +++++++++----- .../flow-form/inputs/review-pending-values.tsx | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/apps/hpc-ftsadmin-e2e/src/support/commands.ts b/apps/hpc-ftsadmin-e2e/src/support/commands.ts index bea671ca4..ab07e071c 100644 --- a/apps/hpc-ftsadmin-e2e/src/support/commands.ts +++ b/apps/hpc-ftsadmin-e2e/src/support/commands.ts @@ -129,6 +129,7 @@ export type DataTest = | `flows-table-header-${string}` // TableHeadersProps.label as value | 'pending-flows-nav-button' | 'pending-flows-bulk-reject-button' + | 'pending-flows-popup' | 'keywords-nav-button' | 'keywords-table-id' | 'keywords-table-name' diff --git a/apps/hpc-ftsadmin-e2e/src/tests/pending-flow.cy.ts b/apps/hpc-ftsadmin-e2e/src/tests/pending-flow.cy.ts index 158dd0f74..bf483179d 100644 --- a/apps/hpc-ftsadmin-e2e/src/tests/pending-flow.cy.ts +++ b/apps/hpc-ftsadmin-e2e/src/tests/pending-flow.cy.ts @@ -20,11 +20,15 @@ describe('hpc-ftsadmin pending-flow', () => { cy.typedGet('flows-table').should('not.exist'); }); - /** - * TODO: Add more checking to the test once edit flow is in the app - */ it('Enter pending-flow', () => { - cy.typedGet('flows-table-row-305776v1').click(); - cy.location('pathname').should('eq', '/flows/305776/1'); + cy.typedGet('flows-table-row-328879v1').find('a').click(); + cy.location('pathname').should('eq', '/flows/328879/1'); + cy.get('span') + .contains( + 'This flow is not active because it has been marked as Pending review' + ) + .should('exist'); + + cy.typedGet('pending-flows-popup').should('have.length', 4); }); }); diff --git a/apps/hpc-ftsadmin/src/app/components/flow-form/inputs/review-pending-values.tsx b/apps/hpc-ftsadmin/src/app/components/flow-form/inputs/review-pending-values.tsx index 21f487faa..15342abf8 100644 --- a/apps/hpc-ftsadmin/src/app/components/flow-form/inputs/review-pending-values.tsx +++ b/apps/hpc-ftsadmin/src/app/components/flow-form/inputs/review-pending-values.tsx @@ -113,7 +113,7 @@ const ReviewPendingValues = ({ }; return ( - +