Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider refactoring to be a generic "find" function that can be used anywhere #381

Open
jenbutongit opened this issue Mar 28, 2022 · 0 comments
Open

consider refactoring to be a generic "find" function that can be used anywhere #381

jenbutongit opened this issue Mar 28, 2022 · 0 comments

Comments

@jenbutongit
Copy link
Contributor

consider refactoring to be a generic "find" function that can be used anywhere. A specialised "findPublishedLawyersPerCountry" can still be used but it will simply set the published = true criteria and pass into the generic function. This ensures we don't have to duplicate SQL in multiple areas if we want to include unpublished records in the resultset, e.g., dashboard list item management page.

Originally posted by @alisalaman-cyb in #380 (comment)
@jenbutongit jenbutongit changed the title consider refactoring to be a generic "find" function that can be used anywhere. A specialised "findPublishedLawyersPerCountry" can still be used but it will simply set the published = true criteria and pass into the generic function. This ensures we don't have to duplicate SQL in multiple areas if we want to include unpublished records in the resultset, e.g., dashboard list item management page. consider refactoring to be a generic "find" function that can be used anywhere Mar 28, 2022
@jenbutongit jenbutongit mentioned this issue Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jenbutongit