Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feed_url, include_css, and fallback_image are expected to have default values defined, but don't #12

Open
cjg89 opened this issue May 11, 2017 · 2 comments
Open

feed_url, include_css, and fallback_image are expected to have default values defined, but don't #12

cjg89 opened this issue May 11, 2017 · 2 comments
Assignees
@cjg89 @jmbarne3 @rjucf @cadie
Labels
bug

Comments

@cjg89
Copy link
Member

cjg89 commented May 11, 2017

feed_url, include_css and fallback_image need to have defaults set in UCF_News_Config::$default_options, since we attempt to reference them here (and fail):
https://github.com/UCF/UCF-News-Plugin/blob/master/includes/ucf-news-config.php#L94-L97
@cjg89 cjg89 added the bug label May 11, 2017
@cjg89 cjg89 self-assigned this May 11, 2017
@cjg89
Copy link
Member Author

cjg89 commented Aug 9, 2017

Is in progress in the config-updates branch.

@jmbarne3
Copy link
Contributor

jmbarne3 commented Mar 18, 2021 •
edited
Loading

This should have been fixed in the v2.3.2 tag.

Nope, I was just wrong on this!

@jmbarne3 jmbarne3 reopened this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjg89 cjg89

@jmbarne3 jmbarne3

@rjucf rjucf

@cadie cadie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cjg89 @jmbarne3 @rjucf @cadie