Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images being written to source/ #82

Closed
trevorcampbell opened this issue Jan 1, 2023 · 3 comments
Closed

Images being written to source/ #82

trevorcampbell opened this issue Jan 1, 2023 · 3 comments
Labels
bug Something isn't working low-priority needs-investigation Further information is requested

Comments

@trevorcampbell
Copy link
Contributor

In Chapter 5, I saw an image being written to the source folder

plot(fig, filename="img/classification1/fig05-more.html", auto_open=False)

We should go through the whole book and ensure that all output is only being written to _build/
@trevorcampbell trevorcampbell added the bug Something isn't working label Jan 1, 2023
@trevorcampbell
Copy link
Contributor Author

I see now why things were set up this way...saving to _build does not seem to work.

It's not great though. We should revisit later. This is not super high priority for now.

@trevorcampbell trevorcampbell mentioned this issue Jan 4, 2023
Closed
@joelostblom joelostblom mentioned this issue Feb 15, 2023
Merged
@trevorcampbell
Copy link
Contributor Author

After #240 , the 3d viz are no longer saved to disk. So this might be stale now. Needs investigation

@trevorcampbell trevorcampbell added the needs-investigation Further information is requested label Sep 14, 2023
@trevorcampbell
Copy link
Contributor Author

Confirmed that this is no longer happening. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low-priority needs-investigation Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorcampbell