feat(NOJIRA-123): Add Webhook toggle funcion #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathio
reviewed
Oct 4, 2023
| @@ -40,6 +40,18 @@ export class Webhooks { | |||
| url: `/forms/${uid}/webhooks`, | |||
| }) | |||
| } | |||
|
|
|||
| public toggle (args: { uid: string, tag: string, enabled: boolean }): Promise<Typeform.API.Webhooks.List> { | |||
| const { uid, tag, enabled } = args | |||
There was a problem hiding this comment.
I tested this and it works nicely. However if the enabled is not provided we assume false value without any further info.
I am thinking about throwing an error when the value is not provided - the API call does not make much sense without it, right? However other API calls do not throw when params are missing either, even if they fail.
Maybe we could address this in as a separate feature / PR. WDYT @picsoung ?
There was a problem hiding this comment.
Thanks for your work man!
We should definitively take advantage to check the params shape, but across all endpoints, before it hits the API.
mathio
changed the title
Just a simple function to toggle enable on a webhook
mathio
approved these changes
Oct 5, 2023
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often need to change the state of a webhook.
The
updatefunction forces you to pass the URL pointing to the webhook.togglejust turns on or off a webhook.