Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PR-40): update theme methods #104

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat(PR-40): update theme methods #104

merged 1 commit into from
Oct 12, 2023

Conversation

mathio
Copy link
Contributor

@mathio mathio commented Oct 10, 2023

Update Typeform.Theme type to include new types from docs: https://www.typeform.com/developers/create/reference/create-theme/

Fix theme.create and theme.update methods to send payload to API.

Update the bin to load payload from a file: params.json as JSON or params.js as JavaScript object. It is easier to pass large payloads like this compared to passing it via command line.

Resolves #67

@mathio mathio marked this pull request as ready for review October 10, 2023 11:25
@mathio mathio requested a review from a team October 10, 2023 11:25
Copy link

@leandro-serafim leandro-serafim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, it looks good

Update `Typeform.Theme` type to include new types from docs:
https://www.typeform.com/developers/create/reference/create-theme/

Fix `theme.create` and `theme.update` methods to send payload to API.

Update the bin to load payload from a file: `params.json` as JSON or
`params.js` as JavaScript object. It is easier to pass large payloads
like this compared to passing it via command line.
@mathio mathio merged commit adccc13 into main Oct 12, 2023
@mathio mathio deleted the themes branch October 12, 2023 12:45
@typeform-ops-gha
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: update to support new Themes API
3 participants