Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail: Dotted circle needs to represent all the marks #25

Closed
vv-monsalve opened this issue Oct 11, 2024 · 2 comments
Closed

Fail: Dotted circle needs to represent all the marks #25

vv-monsalve opened this issue Oct 11, 2024 · 2 comments

Comments

@vv-monsalve
Copy link
Collaborator

🔥 FAIL Ensure dotted circle glyph is present and can attach marks.

The dotted circle character (U+25CC) is inserted by shaping engines before
mark glyphs which do not have an associated base, especially in the context
of broken syllabic clusters.

For fonts containing combining marks, it is recommended that the dotted circle
character be included so that these isolated marks can be displayed properly;
for fonts supporting complex scripts, this should be considered mandatory.

Additionally, when a dotted circle glyph is present, it should be able to
display all marks correctly, meaning that it should contain anchors for all
attaching marks.

A fontmake filter can be used to automatically add a dotted_circle to a font:

fontmake --filter 'DottedCircleFilter(pre=True)' --filter '...'

Original proposal: fonttools/fontbakery#3600

  • 🔥 FAIL

    The following glyphs could not be attached to the dotted circle glyph:

- dagesh-hb

- holam-hb

- holamhaser-hb

- ogonekcomb

- shindot-hb

- sindot-hb

- slashlongcomb

- slashshortcomb

- strokelongcomb

- strokeshortcomb

[code: unattached-dotted-circle-marks]

@vv-monsalve vv-monsalve changed the title [Fail] Dotted circle needs to represent all the marks Fail: Dotted circle needs to represent all the marks Oct 11, 2024
@josescaglione
Copy link
Collaborator

This is sorted already

@vv-monsalve
Copy link
Collaborator Author

After pulling the latest files at commit 8ae1e84 this is no longer reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants