Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bernoulli mixed model calling std function with non-existing kwarg normalize #149

Closed
Cong-SUN opened this issue Nov 29, 2024 · 2 comments · Fixed by #150
Closed

Bernoulli mixed model calling std function with non-existing kwarg normalize #149

Cong-SUN opened this issue Nov 29, 2024 · 2 comments · Fixed by #150

Comments

@Cong-SUN
Copy link

in TuringGLM/0rvqL/src/turing_model.jl:266 it uses std(y; normalize=true), but this function actually doesn't accept normalize as a kwarg: std(x::AbstractArray, w::AbstractWeights, [dim]; mean=nothing, corrected=false).

@penelopeysm
Copy link
Member

std_y=std(y; normalize=true),

@rikhuijzer
Copy link
Collaborator

rikhuijzer commented Nov 30, 2024

in TuringGLM/0rvqL/src/turing_model.jl:266 it uses std(y; normalize=true), but this function actually doesn't accept normalize as a kwarg: std(x::AbstractArray, w::AbstractWeights, [dim]; mean=nothing, corrected=false).

Thanks for reporting this @Cong-SUN. Do you have a reproducible example? What model did you run to get this error? Maybe we can then add a new test that avoids this problem to reappear in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants