Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code for initialising Sampler #768

Closed
xukai92 opened this issue Apr 27, 2019 · 2 comments
Closed

Improve code for initialising Sampler #768

xukai92 opened this issue Apr 27, 2019 · 2 comments

Comments

@xukai92
Copy link
Member

xukai92 commented Apr 27, 2019

Codes are quite inconsistent, including

  • check space
    • sometimes we pass model for this purpose
  • we could simplify a lot of overloading by s::Selector=Selector()
@mohamed82008
Copy link
Member

See the Turing.Inference.init_spl function in #660 which is relevant.

@yebai
Copy link
Member

yebai commented May 3, 2019 •
edited
Loading

Duplicate of #771

@yebai yebai marked this as a duplicate of #746 May 3, 2019
@yebai yebai closed this as completed May 3, 2019
@yebai yebai marked this as a duplicate of #771 May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yebai @xukai92 @mohamed82008