Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoning "Mamba.Chain" #413

Closed
2 tasks
xukai92 opened this issue Dec 31, 2017 · 5 comments
Closed
2 tasks

Abandoning "Mamba.Chain" #413

xukai92 opened this issue Dec 31, 2017 · 5 comments

Comments

@xukai92
Copy link
Member

xukai92 commented Dec 31, 2017

Current use of "Mamba.Chain"leads to problem like #390 and #406. Some of them is very hard to resolve (e.g. #390) within "Mamba.Chain"

For this reason, @yebai and I decided to build our own Chain type now. (FYI the main reason we used Mamba.Chain was to re-use all the diagnosing function written in Mamba). This would requires use to generally build these functions (like ESS) for our own chain type (or somehow reuse them in a way which allow missing values).

For describe function is self, the most important two to implement are

  • ESS
  • MCSE

And for plot, we may use Plot.jl to plot trace and density (in stead of Gadfly.jl).

And don't remember these functions to diagnose convergence in Mamba.jl which are also sort of wanted.

Discussion are encouraged on this!

@keorn
Copy link

keorn commented Jan 4, 2018

Sounds like a good change, it could enable the support of arbitrary sample types too.

@xukai92
Copy link
Member Author

xukai92 commented Jan 9, 2018

Note: fetch matrix indexing (i.e. v[:,i]) from Mamba.Chain is broken now. Need to make sure new solution support it.

@yebai
Copy link
Member

yebai commented Feb 1, 2018

I just noticed that there is already a GSoC project working on the varying dimension constraint of Mamba. According to a blog from the main developer, the refactored Chain (see here) can already store samples with varying sizes. Perhaps we can adapt his code for our purpose?

@xukai92
Copy link
Member Author

xukai92 commented May 23, 2018

Another choice: arviz-devs/arviz#97 (comment)

@yebai
Copy link
Member

yebai commented Sep 7, 2018

Closed by new MCMCChain package.

@yebai yebai closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants