Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMC: Multinomial Sampling Instead of Slice Sampling #62

Closed
wesselb opened this issue Jul 8, 2018 · 3 comments
Closed

HMC: Multinomial Sampling Instead of Slice Sampling #62

wesselb opened this issue Jul 8, 2018 · 3 comments
Milestone

Comments

@wesselb
Copy link

wesselb commented Jul 8, 2018

As mentioned on page 59 in [1], multinomial sampling instead of slice sampling may provide an improvement in overall performance.

[1] https://arxiv.org/abs/1701.02434

@yebai yebai transferred this issue from TuringLang/Turing.jl May 13, 2019
@xukai92
Copy link
Member

xukai92 commented May 22, 2019

@yebai Do you think it make more sense for us to implement this first so that our algorithm is the same as Stan and DHMC before we try to find a possible bug?

@yebai
Copy link
Member

yebai commented May 23, 2019

It sounds good to me, although I suspect that the bug is in the build_tree part of the code. Maybe we can improve the code a bit by implementing the multinomial sampling scheme.

@xukai92
Copy link
Member

xukai92 commented Jul 10, 2019

Closed by PR #79.

@xukai92 xukai92 closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants