Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build select images using arm64 archicecture #104

Closed
q0rban opened this issue Apr 25, 2023 · 2 comments · Fixed by #124
Closed

Build select images using arm64 archicecture #104

q0rban opened this issue Apr 25, 2023 · 2 comments · Fixed by #124

Comments

@q0rban
Copy link
Contributor

q0rban commented Apr 25, 2023

Currently our images are all built for amd64 which works fine for production. But for local development, folks on Apple Silicon may want to build previews from our branches on the https://github.com/TugboatQA/tugboat-test/ repository. We should build arm64 for whatever images those branches use. I believe we are already using buildx, so shouldn't be too tricky there, but we will potentially need some not insignificant refactoring to our makefile / scripts.

@deviantintegral
Copy link
Contributor

I am already building PHP images locally as a part of #102 for ARM. Those seem to work fine.

The biggest issue is if upstream images are using different names for different architectures. I actually don't think there's too much work to do here, unless we want to actually push ARM images up to docker hub or GHCR.

@q0rban
Copy link
Contributor Author

q0rban commented Apr 25, 2023

For building previews on local development installations of Tugboat on Apple silicon, we do need to push them up to docker hub. Otherwise, folks would manually need to build and tag the images locally prior to being able to build a preview on their local Tugboat installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants