Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oasdiff diff result fails to detect changes with --flatten flag #465

Closed
blva opened this issue Dec 19, 2023 · 1 comment
Closed

oasdiff diff result fails to detect changes with --flatten flag #465

blva opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@blva
Copy link
Contributor

blva commented Dec 19, 2023

Describe the bug
oasdiff diff result fails to detect changes with --flatten flag
To Reproduce
Steps to reproduce the behavior:

  1. The command-line,
 ❯ oasdiff diff --flatten  data/spec1_chained_diff.yaml data/spec2_chained_diff.yaml --max-circular-dep 10  --strip-prefix-base /api/atlas/v1.0 --strip-prefix-revision /api/atlas/v2 --match-path "^.+\/(v1.0|v2)\/.+$"
  1. Spec 1
  2. Spec 2
  3. Output
paths:
    modified:
        /subscribe:
            operations:
                modified:
                    GET:
                        responses:
                            modified:
                                "200":
                                    content:
                                        mediaTypeModified:
                                            application/json:
                                                schema:
                                                    items:
                                                        oneOf:
                                                            modified:
                                                                '#/components/schemas/FederationOidcIdentityProvider':
                                                                    oneOf:
                                                                        modified:
                                                                            '#/components/schemas/FederationSamlIdentityProvider':
                                                                                oneOf:
                                                                                    added:
                                                                                        - FederationSamlIdentityProvider
                                                                                        - FederationOidcIdentityProvider
                                                                '#/components/schemas/FederationSamlIdentityProvider':
                                                                    oneOf:
                                                                        added:
                                                                            - FederationSamlIdentityProvider
                                                                            - FederationOidcIdentityProvider
endpoints:
    modified:
        ?   method: GET
            path: /subscribe
        :   responses:
                modified:
                    "200":
                        content:
                            mediaTypeModified:
                                application/json:
                                    schema:
                                        items:
                                            oneOf:
                                                modified:
                                                    '#/components/schemas/FederationOidcIdentityProvider':
                                                        oneOf:
                                                            modified:
                                                                '#/components/schemas/FederationSamlIdentityProvider':
                                                                    oneOf:
                                                                        added:
                                                                            - FederationSamlIdentityProvider
                                                                            - FederationOidcIdentityProvider
                                                    '#/components/schemas/FederationSamlIdentityProvider':
                                                        oneOf:
                                                            added:
                                                                - FederationSamlIdentityProvider
                                                                - FederationOidcIdentityProvider
components:
    schemas:
        modified:
            FederationIdentityProvider:
                oneOf:
                    modified:
                        '#/components/schemas/FederationOidcIdentityProvider':
                            oneOf:
                                modified:
                                    '#/components/schemas/FederationSamlIdentityProvider':
                                        oneOf:
                                            added:
                                                - FederationSamlIdentityProvider
                                                - FederationOidcIdentityProvider
                        '#/components/schemas/FederationSamlIdentityProvider':
                            oneOf:
                                added:
                                    - FederationSamlIdentityProvider
                                    - FederationOidcIdentityProvider
            FederationOidcIdentityProvider:
                oneOf:
                    modified:
                        '#/components/schemas/FederationOidcIdentityProvider':
                            oneOf:
                                modified:
                                    '#/components/schemas/FederationSamlIdentityProvider':
                                        oneOf:
                                            added:
                                                - FederationSamlIdentityProvider
                                                - FederationOidcIdentityProvider
                        '#/components/schemas/FederationSamlIdentityProvider':
                            oneOf:
                                added:
                                    - FederationSamlIdentityProvider
                                    - FederationOidcIdentityProvider
            FederationSamlIdentityProvider:
                oneOf:
                    added:
                        - FederationSamlIdentityProvider
                        - FederationOidcIdentityProvider

Expected behavior
No changes.
Desktop (please complete the following information):

  • OS: [e.g. iOS]

Additional context
Add any other context about the problem here.

@reuvenharrison
Copy link
Collaborator

Fixed by #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants