-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
malformed YAML structure for endpoints #183
Comments
Hi @reuvenharrison, thanks again for your effort. I understood the point but, in my use case, I have two different options right now:
As none looks very interesting I took a look and seems feasible to add the -exclude-endpoints flag, similar to exclude-examples that already exist. I was able to create the core of it (using the existing code as an example), if I submit a PR could you review it? |
Got it. |
Describe the bug
When using the diff with YAML format the Endpoints/Modified structure has a malformed YAML structure because the key is not a string.
To Reproduce
Steps to reproduce the behavior:
oasdiff.exe -format=text -base petstore.yaml -revision petstore_2.yaml -format yaml
Expected behavior
The structure under endpoints/modified can be converted to an array with one "id" structure and the "changes", in this case it will be presented as:
A second alternative is to exclude this structure from the YAML, using a flag or by default.
Desktop (please complete the following information):
Additional context
petstore.yaml at https://gist.githubusercontent.com/peruzzof/affe59e40f5b257751462775775b7b7c/raw/b0d2299c3a3eba76bcb96bf9258bef68aaf50f74/petstore.yaml
petstore_2.yaml at https://gist.githubusercontent.com/peruzzof/affe59e40f5b257751462775775b7b7c/raw/b0d2299c3a3eba76bcb96bf9258bef68aaf50f74/petstore_2.yaml
The text was updated successfully, but these errors were encountered: