Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add Node-Sass Dependency #4389

Closed
wants to merge 1 commit into from
Closed

Re-add Node-Sass Dependency #4389

wants to merge 1 commit into from

Conversation

PaulAdamDavis
Copy link
Member

References #4355 and #4372

There was an issue where Libsass/node-sass would strip media queries (sass/libsass#566 & sass/node-sass#487). It is fixed now, but the dependencies in grunt-sass have not yet been updated.

This PR requires a never version of node-sass which fixes the issue.

References #4355 and #4372

There was an issue where Libsass/node-sass would strip media queries (sass/libsass#566 & sass/node-sass#487). It is fixed now, but the dependencies in grunt-sass have not been updated.
@jaswilli
Copy link
Contributor

jaswilli commented Nov 4, 2014

We're stuck with node-sass < 1.1.10 because newer versions need a compiler that supports the c++11 standard in order to be built.

That's the origin of those two PRs linked above. Semver in grunt-sass got us the new version of node-sass so I had to peg it, and the the grunt-sass project had to do the same thing so I was able to remove the direct dependency.

Basically it's a matter of waiting until Travis uses a newer version of Linux for their images. They're working on it but no ETA.

We will need to make a decision to not directly support installations on things like Ubuntu 12.04. You can get the newer compilers but it's a manual process.

@PaulAdamDavis
Copy link
Member Author

That explains why it failed the tests. :(

So we're stuck between a rock and a hard place?

@PaulAdamDavis
Copy link
Member Author

Closing in favour of #4393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants