Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): traverse up directory tree to find instance #820

Merged
merged 6 commits into from
May 23, 2020

Conversation

vikaspotluri123
Copy link
Member

refs #800

  • Try to go up the directory tree to find a valid Ghost instance
  • Can be disabled with global config ('traverse_dirs')
    • We need to determine if there's a better way of doing this, or how global config should work in general
    • I was thinking of adding a migration which prompts the user, but that feels overkill
  • I want to get a code review before I write the tests 😄

@coveralls
Copy link

coveralls commented Jan 23, 2020

Coverage Status

Coverage remained the same at 99.925% when pulling 2198d18 on vikaspotluri123:feat/find-instance into 4df32ed on TryGhost:master.

Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of super minor comments, otherwise looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants