feat(doctor): add free disk space check #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#1282 - adds doctor check for system free space
acburdine
force-pushed
the
feat/free-space-check
branch
from
0c1665e to
a06247e
Compare
|
|
||
| if (!disk) { | ||
| // couldn't find a matching disk, early return | ||
| // TODO: maybe throw a warning of some sort here? |
There was a problem hiding this comment.
We could have a warning that says Unable to determine available free space. We suggest you have at least 1gb of space available. with a 2s delay 🤔
There was a problem hiding this comment.
eventually I want to have the doctor command actually distinguish between "warnings" and "errors" - left this comment to remember to add a warning here whenever that distinction is possible.
| const MIN_FREE_SPACE = 1024; | ||
|
|
||
| async function checkFreeSpace(ctx) { | ||
| const dir = ctx.instance ? ctx.instance.dir : process.cwd(); |
There was a problem hiding this comment.
Can't wait to ctx.instance?.dir ?? process.cwd() in the future
vikaspotluri123
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.