fix(ui): extract database migrations into a task

no issue
- hide migration output
- extract migration code into a task

Author: acburdine

lib/commands/start.js

@@ -1,12 +1,11 @@
 'use strict';
 const fs = require('fs');
 const path = require('path');
-const KnexMigrator = require('knex-migrator');
 
 const Config = require('../utils/config');
 const Command = require('../command');
-const errors = require('../errors');
 const startupChecks = require('./doctor/checks/startup');
+const runMigrations = require('../tasks/migrate');
 
 class StartCommand extends Command {
     run(argv) {
@@ -21,50 +20,19 @@ class StartCommand extends Command {
             process.env.NODE_ENV = this.environment = 'development';
         }
 
-        return this.ui.listr(startupChecks, {environment: this.environment}).then(() => {
-            config = Config.load(this.environment);
-            cliConfig = Config.load('.ghost-cli');
+        config = Config.load(this.environment);
+        cliConfig = Config.load('.ghost-cli');
 
-            if (cliConfig.has('running')) {
-                return Promise.reject(new Error('Ghost is already running.'));
-            }
+        if (cliConfig.has('running')) {
+            return Promise.reject(new Error('Ghost is already running.'));
+        }
 
+        return this.ui.listr(startupChecks.concat({
+            title: 'Running database migrations',
+            task: runMigrations
+        }), {environment: this.environment, config: config}).then(() => {
             this.service.setConfig(config);
 
-            process.env.paths__contentPath = path.join(process.cwd(), 'content');
-
-            let knexMigrator = new KnexMigrator({
-                knexMigratorFilePath: path.join(process.cwd(), 'current')
-            });
-
-            return knexMigrator.isDatabaseOK().catch((error) => {
-                if (error.code === 'DB_NOT_INITIALISED' ||
-                    error.code === 'MIGRATION_TABLE_IS_MISSING') {
-                    return knexMigrator.init();
-                } else if (error.code === 'DB_NEEDS_MIGRATION') {
-                    return knexMigrator.migrate();
-                }
-
-                if (error.code === 'ENOTFOUND') {
-                    // Database not found
-                    error = new errors.ConfigError({
-                        configKey: 'database.connection.host',
-                        configValue: config.get('database.connection.host'),
-                        message: 'Invalid database host',
-                        environment: this.environment
-                    });
-                } else if (error.code === 'ER_ACCESS_DENIED_ERROR') {
-                    error = new errors.ConfigError({
-                        configKey: 'database.connection.user',
-                        configValue: config.get('database.connection.user'),
-                        message: 'Invalid database username or password',
-                        environment: this.environment
-                    });
-                }
-
-                return Promise.reject(error);
-            });
-        }).then(() => {
             let start = () => Promise.resolve(this.service.process.start(process.cwd(), this.environment)).then(() => {
                 let systemConfig = Config.load('system');
                 let instance = systemConfig.get(`instances.${config.get('pname')}`, {});

lib/tasks/migrate.js

@@ -0,0 +1,49 @@
+'use strict';
+const path = require('path');
+const KnexMigrator = require('knex-migrator');
+
+const errors = require('../errors');
+
+module.exports = function runMigrations(context) {
+    process.env.paths__contentPath = path.join(process.cwd(), 'content');
+    let config = context.config;
+
+    let transports = config.get('logging.transports', null);
+    config.set('logging.transports', ['file']).save();
+
+    let knexMigrator = new KnexMigrator({
+        knexMigratorFilePath: path.join(process.cwd(), 'current')
+    });
+
+    return knexMigrator.isDatabaseOK().catch((error) => {
+        if (error.code === 'DB_NOT_INITIALISED' ||
+            error.code === 'MIGRATION_TABLE_IS_MISSING') {
+            return knexMigrator.init();
+        } else if (error.code === 'DB_NEEDS_MIGRATION') {
+            return knexMigrator.migrate();
+        }
+
+        if (error.code === 'ENOTFOUND') {
+            // Database not found
+            error = new errors.ConfigError({
+                configKey: 'database.connection.host',
+                configValue: config.get('database.connection.host'),
+                message: 'Invalid database host',
+                environment: context.environment
+            });
+        } else if (error.code === 'ER_ACCESS_DENIED_ERROR') {
+            error = new errors.ConfigError({
+                configKey: 'database.connection.user',
+                configValue: config.get('database.connection.user'),
+                message: 'Invalid database username or password',
+                environment: context.environment
+            });
+        }
+
+        config.set('logging.transports', transports).save();
+        return Promise.reject(error);
+    }).then(() => {
+        config.set('logging.transports', transports).save();
+    });
+}
+