fix(ui): improve custom renderer cleanup

acburdine · acburdine · commit da3bac62fdf0 · 2017-06-26T16:19:57.000-04:00
diff --git a/lib/ui/renderer.js b/lib/ui/renderer.js
@@ -83,7 +83,10 @@ class CLIRenderer {
             this.id = undefined;
         }
 
-        this.frame(); // Ensure last spinners are cleared up
+        if (this.spinner) {
+            this.spinner.stop();
+            this.spinner = this.ui.spinner = null;
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,10 @@ class CLIRenderer {`
`83`	`83`	`this.id = undefined;`
`84`	`84`	`}`
`85`	`85`
`86`		`- this.frame(); // Ensure last spinners are cleared up`
	`86`	`+ if (this.spinner) {`
	`87`	`+ this.spinner.stop();`
	`88`	`+ this.spinner = this.ui.spinner = null;`
	`89`	`+ }`
`87`	`90`	`}`
`88`	`91`	`}`
`89`	`92`