fix(config): ensure port number is treated as an integer (#452)

closes #451 
- ensure port number is treated as an integer so portfinder increments it correctly
- update tests to reflect new behavior

Author: TomChantler

lib/commands/config/advanced.js

@@ -6,7 +6,7 @@ const includes = require('lodash/includes');
 const validator = require('validator');
 const url = require('url');
 
-const BASE_PORT = '2368';
+const BASE_PORT = 2368;
 const knownMailServices = [
     'aol', 'dynectemail', 'fastmail', 'gmail', 'godaddy', 'godaddyasia', 'godaddyeurope', 'hot.ee', 'hotmail', 'icloud',
     'mail.ee', 'mail.ru', 'mailgun', 'mailjet', 'mandrill', 'postmark', 'qq', 'qqex', 'sendgrid',
@@ -47,12 +47,12 @@ module.exports = {
                 return 'Port must be an integer.';
             }
 
-            return portfinder.getPortPromise({port: value}).then((port) => {
-                return (port === value) || `Port '${value}' is in use.`;
+            return portfinder.getPortPromise({port: parseInt(value)}).then((port) => {
+                return (parseInt(port) === parseInt(value)) || `Port '${value}' is in use.`;
             });
         },
         defaultValue: config => {
-            let port = url.parse(config.get('url')).port || BASE_PORT;
+            let port = parseInt(url.parse(config.get('url')).port || BASE_PORT);
             return portfinder.getPortPromise({port: port});
         },
         default: 2368,

test/unit/commands/config-spec.js

@@ -401,10 +401,10 @@ describe('Unit: Command > Config', function () {
                 expect(results.validateExpectsTrue).to.be.true;
                 expect(results.validateExpectsMessage).to.match(/'2366' is in use/);
 
-                expect(portPromiseStub.calledWithExactly({ port: '2366' })).to.be.true;
-                expect(portPromiseStub.calledWithExactly({ port: '2367' })).to.be.true;
-                expect(portPromiseStub.calledWithExactly({ port: '2368' })).to.be.true;
-                expect(portPromiseStub.calledWithExactly({ port: '2369' })).to.be.true;
+                expect(portPromiseStub.calledWithExactly({ port: 2366 })).to.be.true;
+                expect(portPromiseStub.calledWithExactly({ port: 2367 })).to.be.true;
+                expect(portPromiseStub.calledWithExactly({ port: 2368 })).to.be.true;
+                expect(portPromiseStub.calledWithExactly({ port: 2369 })).to.be.true;
             });
         });
     });