fix(utils): prerelease statisfies engine definition

allouis · acburdine · commit 8bfcc38f76ff · 2019-10-17T06:20:35.000-04:00
When testing installs with a prerelease version of the CLI the satisfy
check against Ghosts engines field in package.json fails.
diff --git a/lib/utils/version.js b/lib/utils/version.js
@@ -166,7 +166,7 @@ const utils = {
             return Promise.reject(new SystemError('Zip file contains a Ghost version incompatible with the current Node version.'));
         }
 
-        if (pkg.engines && pkg.engines.cli && !semver.satisfies(cliPackage.version, pkg.engines.cli)) {
+        if (pkg.engines && pkg.engines.cli && !semver.satisfies(cliPackage.version, pkg.engines.cli, {includePrerelease: true})) {
             return Promise.reject(new SystemError({
                 message: 'Zip file contains a Ghost version incompatible with this version of the CLI.',
                 help: `Required: v${pkg.engines.cli}, current: v${cliPackage.version}`,

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ const utils = {`
`166`	`166`	`return Promise.reject(new SystemError('Zip file contains a Ghost version incompatible with the current Node version.'));`
`167`	`167`	`}`
`168`	`168`
`169`		`- if (pkg.engines && pkg.engines.cli && !semver.satisfies(cliPackage.version, pkg.engines.cli)) {`
	`169`	`+ if (pkg.engines && pkg.engines.cli && !semver.satisfies(cliPackage.version, pkg.engines.cli, {includePrerelease: true})) {`
`170`	`170`	`return Promise.reject(new SystemError({`
`171`	`171`	`message: 'Zip file contains a Ghost version incompatible with this version of the CLI.',`
`172`	`172`	help: `Required: v${pkg.engines.cli}, current: v${cliPackage.version}`,