Skip to content

Commit 8a17c8b

Browse files
authored
fix(resolve-version): sort versions before retrieving latest (#939)
1 parent f479cf1 commit 8a17c8b

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/utils/resolve-version.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ module.exports = function resolveVersion(version, activeVersion, v1 = false, for
4343
}
4444

4545
return packageInfo('ghost', {allVersions: true}).then((result) => {
46-
const versions = Object.keys(result.versions).filter(v => semver.satisfies(v, comparator));
46+
const versions = Object.keys(result.versions).filter(v => semver.satisfies(v, comparator)).sort(semver.compare);
4747

4848
if (!versions.length) {
4949
return Promise.reject(new errors.CliError({

test/unit/utils/resolve-version-spec.js

+6
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,12 @@ describe('Unit: resolveVersion', function () {
9090
expect(version).to.equal('1.52.37');
9191
});
9292
});
93+
94+
it('resolves with latest version if 1.x release is newer than latest 2.x', async function () {
95+
const resolveVersion = stub(['1.0.0', '1.0.1', '2.0.0', '2.0.1', '1.0.2']);
96+
const version = await resolveVersion();
97+
expect(version).to.equal('2.0.1');
98+
});
9399
});
94100

95101
describe('with existing version', function () {

0 commit comments

Comments
 (0)