fix(template): log successful created template in all cases

no issue
- previously it would only log if the template was being linked to somewhere on the system, this led to some confusing/inconsistent behavior

Author: acburdine

lib/instance.js

@@ -266,9 +266,12 @@ class Instance {
             () => fs.writeFile(tmplFile, contents)
         ];
 
+        // Dir is optional, if a file just needs to be created locally
+        // so we log here
+        this.ui.success(`Creating ${descriptor} file at ${tmplFile}`);
+
         if (dir) {
             let outputLocation = path.join(dir, file);
-            this.ui.success(`Creating ${descriptor} file at ${tmplFile}`);
             promises.push(() => this.ui.sudo(`ln -sf ${tmplFile} ${outputLocation}`));
         }
 

test/unit/instance-spec.js

@@ -474,7 +474,7 @@ describe('Unit: Instance', function () {
                 let fpath = path.join(dir, 'system', 'files', 'file.txt');
                 expect(fs.existsSync(fpath)).to.be.true;
                 expect(fs.readFileSync(fpath, 'utf8')).to.equal('some contents');
-                expect(successStub.called).to.be.false;
+                expect(successStub.calledOnce).to.be.true;
             });
         });