feat(install): cleanup install directory on error

Author: acburdine

lib/commands/install.js

@@ -1,3 +1,4 @@
+const fs = require('fs-extra');
 const path = require('path');
 const Command = require('../command');
 const symlinkSync = require('symlink-or-copy').sync;
@@ -49,31 +50,36 @@ class InstallCommand extends Command {
             local
         });
 
-        await this.ui.listr([{
-            title: 'Checking for latest Ghost version',
-            task: this.version
-        }, {
-            title: 'Setting up install directory',
-            task: ensureStructure
-        }, {
-            title: 'Downloading and installing Ghost',
-            task: (ctx, task) => {
-                task.title = `Downloading and installing Ghost v${ctx.version}`;
-                return yarnInstall(ctx.ui, ctx.argv.zip);
-            }
-        }, {
-            title: 'Finishing install process',
-            task: () => this.ui.listr([{
-                title: 'Linking latest Ghost and recording versions',
-                task: this.link.bind(this)
+        try {
+            await this.ui.listr([{
+                title: 'Checking for latest Ghost version',
+                task: this.version
             }, {
-                title: 'Linking latest Casper',
-                task: this.casper
-            }], false)
-        }], {
-            argv: {...argv, version},
-            cliVersion: this.system.cliVersion
-        });
+                title: 'Setting up install directory',
+                task: ensureStructure
+            }, {
+                title: 'Downloading and installing Ghost',
+                task: (ctx, task) => {
+                    task.title = `Downloading and installing Ghost v${ctx.version}`;
+                    return yarnInstall(ctx.ui, ctx.argv.zip);
+                }
+            }, {
+                title: 'Finishing install process',
+                task: () => this.ui.listr([{
+                    title: 'Linking latest Ghost and recording versions',
+                    task: this.link.bind(this)
+                }, {
+                    title: 'Linking latest Casper',
+                    task: this.casper
+                }], false)
+            }], {
+                argv: {...argv, version},
+                cliVersion: this.system.cliVersion
+            });
+        } catch (error) {
+            this.cleanInstallDirectory();
+            throw error;
+        }
 
         if (!argv.setup) {
             return;
@@ -140,6 +146,11 @@ class InstallCommand extends Command {
         instance.cliVersion = this.system.cliVersion;
         instance.channel = ctx.argv.channel || 'stable';
     }
+
+    cleanInstallDirectory() {
+        const cwd = process.cwd();
+        fs.readdirSync(cwd).map(file => fs.removeSync(file));
+    }
 }
 
 InstallCommand.global = true;

test/unit/commands/install-spec.js

@@ -3,6 +3,7 @@ const sinon = require('sinon');
 const proxyquire = require('proxyquire').noCallThru();
 const Promise = require('bluebird');
 const path = require('path');
+const fs = require('fs-extra');
 
 const modulePath = '../../../lib/commands/install';
 const errors = require('../../../lib/errors');
@@ -34,6 +35,10 @@ describe('Unit: Commands > Install', function () {
             sinon.restore();
         });
 
+        beforeEach(() => {
+            sinon.stub(fs, 'removeSync');
+        });
+
         it('rejects if directory is not empty', function () {
             const dirEmptyStub = sinon.stub().returns(false);