fix(config): disallow URLs ending with /ghost

Author: vikaspotluri123

lib/commands/config/advanced.js

@@ -21,8 +21,15 @@ const knownMailServices = [
 module.exports = {
     url: {
         description: 'Blog URL with protocol E.g. http://loveghost.com',
-        validate: value => validator.isURL(value, {require_protocol: true}) ||
-            'Invalid URL. Your URL should include a protocol, E.g. http://my-ghost-blog.com',
+        validate: (value) => {
+            const urlValidation = validator.isURL(value, {require_protocol: true});
+            const endsWithGhost = new RegExp('(?:/ghost/?)$', 'i');
+            if (urlValidation) {
+                return (!endsWithGhost.test(value)) || 'Ghost doesn\'t support running in a path that ends with `ghost`';
+            }
+
+            return 'Invalid URL. Your URL should include a protocol, E.g. http://my-ghost-blog.com';
+        },
         transform: value => value.toLowerCase(),
         type: 'string',
         group: 'Ghost Options:'

lib/commands/config/index.js

@@ -103,8 +103,15 @@ class ConfigCommand extends Command {
                 name: 'url',
                 message: 'Enter your blog URL:',
                 default: this.instance.config.get('url', 'http://localhost:2368'),
-                validate: (value) => validator.isURL(value, {require_protocol: true}) ||
-                    'Invalid URL. Your URL should include a protocol, E.g. http://my-ghost-blog.com'
+                validate: (value) => {
+                    const urlValidation = validator.isURL(value, {require_protocol: true});
+                    const endsWithGhost = new RegExp('(?:/ghost/?)$', 'i');
+                    if (urlValidation) {
+                        return (!endsWithGhost.test(value)) || 'Ghost doesn\'t support running in a path that ends with `ghost`';
+                    }
+
+                    return 'Invalid URL. Your URL should include a protocol, E.g. http://my-ghost-blog.com';
+                }
             });
         }
 

test/unit/commands/config-spec.js

@@ -190,6 +190,7 @@ describe('Unit: Command > Config', function () {
             expect(result[0].name).to.equal('url');
             expect(result[0].validate('http://localhost:2368')).to.be.true;
             expect(result[0].validate('notaurl')).to.match(/Invalid URL/);
+            expect(result[0].validate('https://localhost:2368/ghost')).to.match(/path that ends with `ghost`/);
         });
 
         it('returns db prompts if db arg not provided', function () {
@@ -471,6 +472,7 @@ describe('Unit: Command > Config', function () {
             expect(advancedOptions.url.validate('http://localhost:2368')).to.be.true;
             expect(advancedOptions.url.validate('localhost:2368')).to.match(/Invalid URL/);
             expect(advancedOptions.url.validate('not even remotely a URL')).to.match(/Invalid URL/);
+            expect(advancedOptions.url.validate('http://localhost:2368/ghost')).to.match(/path that ends with `ghost`/);
 
             // Check transform function
             expect(advancedOptions.url.transform('http://MyUpperCaseUrl.com')).to.equal('http://myuppercaseurl.com');