fix(backup): handle local + server permissions

refs: TryGhost/Toolbox#334
refs: #468

- we have to handle files differently depending on whether we're working locally or on a server
- first pass worked locally, second worked on ubuntu, this one should work on both

Author: ErisDS

lib/tasks/backup.js

@@ -4,9 +4,47 @@ const debug = require('debug')('ghost-cli:backup');
 const execa = require('execa');
 const fs = require('fs-extra');
 
+const ghostUser = require('../utils/use-ghost-user');
 const {ProcessError} = require('../errors');
 const {exportTask} = require('./import');
 
+async function ensureBackupFolder(ui, instance) {
+    const folderName = '../backup';
+
+    const contentDir = instance.config.get('paths.contentPath');
+    if (ghostUser.shouldUseGhostUser(contentDir)) {
+        const {USER} = process.env;
+        await ui.sudo(`mkdir -p ${path.resolve(contentDir, folderName)}`, {sudoArgs: `-E -u ${USER}`});
+    } else {
+        fs.ensureDirSync(path.resolve(contentDir, folderName));
+    }
+}
+
+async function copyFiles(ui, instance, files) {
+    const contentDir = instance.config.get('paths.contentPath');
+    const shouldUseSudo = ghostUser.shouldUseGhostUser(contentDir);
+
+    for (const fileKey in files) {
+        const filePath = path.join(instance.dir, fileKey);
+        const fileExists = fs.existsSync(filePath);
+
+        if (fileExists) {
+            debug(`copying ${fileKey} to ${files[fileKey]}`);
+
+            const destinationFilePath = path.join(instance.dir, files[fileKey]);
+            if (shouldUseSudo) {
+                await ui.sudo(`cp ${filePath} ${destinationFilePath}`);
+            } else {
+                await fs.copy(filePath, destinationFilePath);
+            }
+        }
+    }
+
+    if (shouldUseSudo) {
+        await ui.sudo(`chown -R ghost:ghost ${contentDir}`);
+    }
+}
+
 module.exports = async function (ui, instance) {
     const datetime = require('moment')().format('YYYY-MM-DD-HH-mm-ss');
     const backupSuffix = `from-v${instance.version}-on-${datetime}`;
@@ -16,9 +54,7 @@ module.exports = async function (ui, instance) {
     const membersExportFile = `members-${backupSuffix}.csv`;
 
     // Ensure the backup directory exists and has write permissions
-    const {USER} = process.env;
-    await ui.sudo(`mkdir -p ${path.join(instance.dir, 'backup')}`);
-    await ui.sudo(`chown -R ${USER}:${USER} ${path.join(instance.dir, 'backup')}`);
+    await ensureBackupFolder(ui, instance);
 
     // Generate backup files
     await exportTask(ui, instance, path.join(instance.dir, 'backup/', contentExportFile), path.join(instance.dir, 'backup/', membersExportFile));
@@ -32,19 +68,7 @@ module.exports = async function (ui, instance) {
         [`backup/${membersExportFile}`]: `content/data/${membersExportFile}`
     };
 
-    for (const backupFilesKey in backupFiles) {
-        const filePath = path.join(instance.dir, backupFilesKey);
-        const fileExists = fs.existsSync(filePath);
-
-        if (fileExists) {
-            debug(`copying ${backupFilesKey} to ${backupFiles[backupFilesKey]}`);
-
-            const destinationFilePath = path.join(instance.dir, backupFiles[backupFilesKey]);
-            await ui.sudo(`cp ${filePath} ${destinationFilePath}`);
-        }
-    }
-
-    await ui.sudo(`chown -R ghost:ghost ${path.join(instance.dir, 'content')}`);
+    await copyFiles(ui, instance, backupFiles);
 
     // Finally we zip everything up into a nice little package
     const zipPath = path.join(process.cwd(), `backup-${backupSuffix}.zip`);