feat(update): run doctor checks on ghost update

no issue
- run update checks

Author: acburdine

lib/commands/doctor/checks/content-folder.js

@@ -39,5 +39,5 @@ module.exports = {
     title: 'Content folder permissions',
     enabled: () => shouldUseGhostUser(path.join(process.cwd(), 'content')),
     task: contentFolderPermissions,
-    category: ['start']
+    category: ['start', 'update']
 }

lib/commands/doctor/checks/folder-permissions.js

@@ -21,5 +21,5 @@ Please fix your directory permissions.`));
 module.exports = {
     title: 'Checking current folder permissions',
     task: folderPermissions,
-    category: ['install']
+    category: ['install', 'update']
 };

lib/commands/doctor/checks/node-version.js

@@ -24,5 +24,5 @@ See ${chalk.underline.blue('https://docs.ghost.org/v1/docs/supported-node-versio
 module.exports = {
     title: 'Checking system Node.js version',
     task: nodeVersion,
-    category: ['install']
+    category: ['install', 'update']
 };

lib/commands/update.js

@@ -11,6 +11,7 @@ class UpdateCommand extends Command {
         const chalk = require('chalk');
         const semver = require('semver');
 
+        const DoctorCommand = require('./doctor');
         const MigrateCommand = require('./migrate');
         const migrate = require('../tasks/migrate');
 
@@ -77,7 +78,12 @@ class UpdateCommand extends Command {
             task: this.removeOldVersions
         }];
 
-        return this.runCommand(MigrateCommand, {quiet: true}).then(() => {
+        return this.runCommand(DoctorCommand, Object.assign(
+            {quiet: true, categories: ['update']},
+            argv
+        )).then(() => {
+            return this.runCommand(MigrateCommand, {quiet: true})
+        }).then(() => {
             return this.ui.run(() => this.version(context), 'Checking for latest Ghost version');
         }).then((result) => {
             if (!result) {

test/unit/commands/update-spec.js

@@ -34,7 +34,7 @@ describe('Unit: Commands > Update', function () {
             const runCommandStub = sinon.stub(cmdInstance, 'runCommand').resolves();
 
             return cmdInstance.run({version: '1.0.0', force: false, zip: ''}).then(() => {
-                expect(runCommandStub.calledOnce).to.be.true;
+                expect(runCommandStub.calledTwice).to.be.true;
                 expect(ui.run.calledOnce).to.be.true;
                 expect(versionStub.calledOnce).to.be.true;
                 expect(versionStub.args[0][0]).to.deep.equal({
@@ -77,7 +77,7 @@ describe('Unit: Commands > Update', function () {
             return cmdInstance.run({rollback: true}).then(() => {
                 expect(false, 'error should have been thrown').to.be.true;
             }).catch((error) => {
-                expect(runCommandStub.calledOnce).to.be.false;
+                expect(runCommandStub.called).to.be.false;
                 expect(error).to.be.an.instanceof(Error);
                 expect(error.message).to.equal('No previous version found');
                 expect(ui.run.called).to.be.false;
@@ -109,7 +109,7 @@ describe('Unit: Commands > Update', function () {
             const cwdStub = sinon.stub(process, 'cwd').returns(fakeInstance.dir);
 
             return cmdInstance.run({rollback: true, force: false, zip: ''}).then(() => {
-                expect(runCommandStub.calledOnce).to.be.true;
+                expect(runCommandStub.calledTwice).to.be.true;
                 cwdStub.restore();
 
                 expect(ui.run.calledOnce).to.be.true;
@@ -172,7 +172,7 @@ describe('Unit: Commands > Update', function () {
             return cmdInstance.run({version: '1.1.0', rollback: false, force: false, restart: true}).then(() => {
                 cwdStub.restore();
 
-                expect(runCommandStub.calledOnce).to.be.true;
+                expect(runCommandStub.calledTwice).to.be.true;
                 expect(ui.run.calledOnce).to.be.true;
                 expect(versionStub.calledOnce).to.be.true;
                 expect(ui.log.called).to.be.false;
@@ -238,7 +238,7 @@ describe('Unit: Commands > Update', function () {
                     zip: ''
                 };
 
-                expect(runCommandStub.calledOnce).to.be.true;
+                expect(runCommandStub.calledTwice).to.be.true;
                 expect(ui.run.calledOnce).to.be.true;
                 expect(versionStub.calledOnce).to.be.true;
                 expect(versionStub.args[0][0]).to.deep.equal(expectedCtx);
@@ -301,7 +301,7 @@ describe('Unit: Commands > Update', function () {
                     zip: ''
                 };
 
-                expect(runCommandStub.calledOnce).to.be.true;
+                expect(runCommandStub.calledTwice).to.be.true;
                 expect(ui.run.calledOnce).to.be.true;
                 expect(versionStub.calledOnce).to.be.true;
                 expect(versionStub.args[0][0]).to.deep.equal(expectedCtx);