Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agenda, background job worker from v1 to v2 #754

Closed
simison opened this issue Oct 21, 2018 · 3 comments
Closed

Update Agenda, background job worker from v1 to v2 #754

simison opened this issue Oct 21, 2018 · 3 comments

Comments

@simison
Copy link
Contributor

simison commented Oct 21, 2018

Agenda v2 was a complete rewrite to support promises instead of callbacks.

Agenda is run in the background worker to process jobs. Main app and the worker run separately in parallel with npm start.

v2 changelog: https://github.com/agenda/agenda/blob/master/History.md#200--2018-07-19

Rewrite needed mainly at:

I'm not sure if we should wait for ES5 → ES6 migration before updating Agenda, because we could jump directly using async/await -format (that we don't support at the moment).

@mrkvon
Copy link
Contributor

mrkvon commented Oct 24, 2018

Do we already have an issue about the migration ES5 -> ES6+? It's been coming up on different occasions.

It will need a change in linter and some period in which it will be ok to write the code in ES 2017.

The ./eslintrc may need { "parserOptions": { "ecmaVersion": 8 } } for support of async/await syntax. I don't know how this will affect Angularjs code. By this action we'll also drop support for older versions of nodejs. I.e. prior to 9.11.2. If we target ES2018, ("ecmaVersion": 9), we'll need nodejs v10.3.0+

@simison
Copy link
Contributor Author

simison commented Nov 3, 2018

@mrkvon opened one here to keep track of ES6 migration: #804

@github-actions
Copy link

This issue is marked as unloved because it has not had any activity for 180 days.

It doesn't mean it's not important, so please remove the unloved label if you like it, or add a comment saying what it means to you :) If this was a bug, maybe you can test to see if this is still an issue?

However, if you just leave it like this, I'll close it in 14 days to help keep your issues tidy!

Thanks!

@simison simison reopened this Jun 17, 2020
@github-actions github-actions bot closed this as completed Jul 2, 2020
@simison simison reopened this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants