Add support for <fullTestName>_SET_RUN_SERIAL=[ON|OFF] (trilinos/Trilinos#7112) #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriBITSPub#173, trilinos/Trilinos#7112) Turns out that TRIBITS_ADD_TEST() had bad logic for reading in <fullTestName>_SET_RUN_SERIAL and <fullTestName>_SET_DISABLED_AND_MSG when the test name is modifed by setting TPL_ENABLE_MPI=ON or passing in NAME_POSTFIX or POSTFIX_AND_ARGS_<IDX> arguments. These are obvious use cases that I missed and they are needed for trilinos/Trilinos#7112 and in general, obviously. This means that <fullTestName>_SET_DISABLED_AND_MSG was not implemented correctly for TRIBITS_ADD_TEST() as part of TriBITSPub#173. Turns out the driving use case for that was using TRIBITS_ADD_ADVACED_TEST() so we never noticed the bug. The next commit will fix this (which I already prototyped).
…e modifications (#7112) This makes the updated (failing) unit tests in the last commit pass (see that commit message for details).
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Sep 19, 2020
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit cee1980d053ec2c26301d2389c8b0a677fa262fe Author: Roscoe A. Bartlett <[email protected]> Date: Sat Sep 19 07:40:49 2020 -0600 Summary: Merge remote-tracking branch 'rab-github/tril-7112-run-serial' (#7112) This represents the changes in the TriBITS PRs: * TriBITSPub/TriBITS#327 : Fix install for MacOSX (#7881) * TriBITSPub/TriBITS#328 : Add support for <fullTestName>_SET_RUN_SERIAL=[ON|OFF] (#7112)
|
@jmgate, any time to review this one? |
e10harvey
reviewed
Sep 22, 2020
|
@e10harvey, thanks for the helpful review. I think the updated unit tests will be better given you feedback. (I will post a follow-on PR for those fixes.) |
|
Sorry, @bartlettroscoe, I didn't get a notification again. I've tweaked my notification settings one more time to see if the emails finally start coming in. |
|
@bartlettroscoe, I'm remembering from a long time ago that there are occasionally issues that come up with GitHub notification emails not getting through to Sandia email addresses. Do you recall any details of that problem, or what the solution was? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the option
<fullTestName>_SET_RUN_SERIAL=[ON|OFF]described in trilinos/Trilinos#7112. This will be used on the Trilinos side immediately to setRUN_SERIALon several Trilinos tests that are timing out in one of the builds on 'ride'. (I tested and settingRUN_SERIALeliminates these timeouts. I will document that testing more completely in the matching Trilinos PR shortly.)How was this tested?
There are strong unit tests for this and, again, I validated this against Trilinos. I used this TriBITS branch with a matching Trilinos branch to run the full build
Trilinos-atdm-white-ride-gnu-7.2.0-openmp-debug-expwhich posted to CDash:Looking at the configure results showed:
and the cache file showed:
Again, more validation evidence will be given in the matching Trilinos PR that will be created shortly.