NETCDF: Fix search of netcdf_meta #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To determine whether NetCDF is compiled for parallel, we search the `netcdf_meta.h` file for the setting of `NETCDF_PARALLEL`. The problem is that the NetCDF team recently added another setting which is named `NETCDF_PARALLEL4`. We want the `NETCDF_PARALLEL` so to make sure we get that one only, we add a space to the end of the symbol `NETCDF_PARALLEL `
bartlettroscoe
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Seems logical to me. If @gsjaardema tested this and he says it works, that is good enough to me.
@gsjaardema, after the merge to TriBITS 'master', how urgent is it to get this into the Trilinos 'develop' branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine whether NetCDF is compiled for parallel, we search the
netcdf_meta.hfile for the setting ofNETCDF_PARALLEL. The problem is that the NetCDF team recently added another setting which is namedNETCDF_PARALLEL4. We want theNETCDF_PARALLELso to make sure we get that one only, we add a space to the end of the symbolNETCDF_PARALLEL