Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back default FIND_PACKAGE() for BLAS and LAPACK FindTPL<TPLNAME>.cmake modules #89

Open
nschloe opened this issue Oct 30, 2015 · 4 comments

Comments

@nschloe
Copy link
Contributor

nschloe commented Oct 30, 2015

Reverted by Sandia bug https://software.sandia.gov/bugzilla/show_bug.cgi?id=6452.

@bartlettroscoe
Copy link
Member

See #69, #59, #81.

NOTE: I did not revert anything in the TirBITS repo. I only reverted the snapshot commit to Trilinos. The new sync model of TriBITS to Trilinos described here merges instead of overwrites changes in Trilinos. Also, I did not revert the HDF5 changes, just the BLAS and LAPACK changes.

Therefore, you can just add new commits in TriBITS to fix this. I suspect this will require special TriBITS logic in the generation of the Makefile.export. file that knows you are on a Mac and knows to convert /System/Library/Frameworks/Accelerate.framework to -framework Accelerate automatically. Given that pattern, that sounds like it might not be too hard? Should be able to come up a utility function with an automated test to make sure it converts the paths it should convert and not the paths it should not. But there needs to be an automated test of some type to pin down and protect this behavior. See Contributing to TriBITS. I can give suggestions on where this would be added.

@mhoemmen, can you get with Nico and test his changes on a TriBITS branch?

@mhoemmen
Copy link
Contributor

On 10/30/15, 5:17 PM, "Roscoe A. Bartlett" <[email protected]mailto:[email protected]> wrote:

@mhoemmenhttps://github.com/mhoemmen, can you get with Nico and test his changes on a TriBITS branch?

Gladly! I am running out of time tonight but should have time over the next few days to check.

mfh

@bartlettroscoe
Copy link
Member

Hold your horses Mark, Nico does not work that fast!

@mhoemmen
Copy link
Contributor

mhoemmen commented Nov 1, 2015

Haha, no worries then! Just let me know when I should start :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants