Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ScreenSpace): add component, demo, docs #536

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat(ScreenSpace): add component, demo, docs #536

merged 4 commits into from
Dec 4, 2024

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Nov 24, 2024 •
edited
Loading

Port of Drei's <ScreenSpace />. Adds:

  • component
  • demo
  • docs

@netlify Netlify
Copy link

netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit d648d60
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/67508a792a264f0008d460a6
😎 Deploy Preview https://deploy-preview-536--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 24, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@536

commit: d648d60

@andretchen0 andretchen0 marked this pull request as ready for review November 24, 2024 08:54
@andretchen0 andretchen0 added the feature New feature or request label Nov 24, 2024
alvarosabu
alvarosabu approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andretchen0 I just changed a minor thing really quick in the last commit, you don't really need to use props on vue templates.

@alvarosabu alvarosabu added the p3-significant High-priority enhancement (priority) label Dec 4, 2024
@alvarosabu alvarosabu merged commit e43f112 into main Dec 4, 2024
8 checks passed
@andretchen0 andretchen0 deleted the feat/screen-space branch December 4, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees
No one assigned
Labels
feature New feature or request p3-significant High-priority enhancement (priority)
Projects
Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andretchen0 @alvarosabu