Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy Between Documentation and Default Value for enableDamping in OrbitControls #447

Closed
5 tasks done
XnetLoL opened this issue Jul 12, 2024 · 1 comment · Fixed by #486
Closed
5 tasks done
Labels
p1-chore Doesn't change end-user code behavior (priority) PR Welcome

Comments

@XnetLoL
Copy link

XnetLoL commented Jul 12, 2024

Describe the bug

There is a discrepancy between the documentation and the implementation regarding the default value of the enableDamping property in OrbitControls. The documentation states that enableDamping should be false by default, but in the code, it is set to true.
Line 237

Reproduction

https://stackblitz.com/edit/tresjs-basic-ldqdkm?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

Just use OrbitControls with default arguments.

System Info

No response

Used Package Manager

npm

Code of Conduct

Copy link

stackblitz bot commented Jul 12, 2024

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change end-user code behavior (priority) PR Welcome
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants