Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking tests due to old exposed version #60

Closed
ChristianSch opened this issue Dec 10, 2021 · 1 comment
Closed

breaking tests due to old exposed version #60

ChristianSch opened this issue Dec 10, 2021 · 1 comment
Labels

Comments

@ChristianSch
Copy link
Contributor

HI!

the root cause of our failing tests (#54) apparently hasn't been fixed in exposed v0.32.1 but needs 0.33.1, which is also quite old and newer versions need major changes apparently. that's why I made a PR (#59) a while ago to have dependabot make PRs for available updates to keep up. it's quite important to be up to date in the database layer because of vulnerabilities of dependencies.

right now we help ourselves with the following hack in our gradle config, which is quite ugly and also deprecated:

    // forces exposed to be > 0.33.1, fixing failing tests. this is a transitive dependency of krush
    // we can remove this extra config after krush updates exposed
    api("org.jetbrains.exposed:exposed-jdbc:$exposedVersion") {
        isForce = true
    }
    api("org.jetbrains.exposed:exposed-core:$exposedVersion") {
        isForce = true
    }
    api("org.jetbrains.exposed:exposed-java-time:$exposedVersion") {
        isForce = true
    }
@pjagielski
Copy link
Collaborator

Fixed in 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants