You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
When resuming a download, files which were already downloaded are accounted for as part of the download phase.
Reproduction steps:
Start installing the game
Cancel game installation
Restart the launcher
Start installing the game
Expected behavior: Already downloaded files do not count towards download progress and total
Actual behavior: Already downloaded files count towards download progress and total, causing incorrect download speed calculations.
The text was updated successfully, but these errors were encountered:
Just as a note here:
Downloads will resume from where they left off already if the patch\download folder contains items, i am however unsure if the launcher does any hash checking on this which will be needed.
ToDo: Check if the already existing items are subject to hashing checks, if not implement this.
edit
Confirmed: Already existing files are hash checked.
This works with #22 when the user cancels the download and starts it again later - however an extra dialog perhaps upon pressing Cancel to state "Are you sure?" and "You can resume this download later" might be useful to the end user.
With those changes in place, I'll rephrase this to focus on resolving the bug where resumed download files are checked and accounted for in the download phase rather than the verification phase.
When resuming a download, files which were already downloaded are accounted for as part of the download phase.
Reproduction steps:
Expected behavior: Already downloaded files do not count towards download progress and total
Actual behavior: Already downloaded files count towards download progress and total, causing incorrect download speed calculations.
The text was updated successfully, but these errors were encountered: