Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

Download speed incorrect when resuming downloads #1

Open
JAJames opened this issue Jan 5, 2018 · 3 comments
Open

Download speed incorrect when resuming downloads #1

JAJames opened this issue Jan 5, 2018 · 3 comments
Labels
bug Something isn't working Normal Priority

Comments

@JAJames
Copy link
Contributor

JAJames commented Jan 5, 2018

When resuming a download, files which were already downloaded are accounted for as part of the download phase.

Reproduction steps:

  1. Start installing the game
  2. Cancel game installation
  3. Restart the launcher
  4. Start installing the game

Expected behavior: Already downloaded files do not count towards download progress and total
Actual behavior: Already downloaded files count towards download progress and total, causing incorrect download speed calculations.

@AlienXAXS
Copy link
Contributor

AlienXAXS commented Jan 19, 2018

Just as a note here:
Downloads will resume from where they left off already if the patch\download folder contains items, i am however unsure if the launcher does any hash checking on this which will be needed.

ToDo: Check if the already existing items are subject to hashing checks, if not implement this.

edit
Confirmed: Already existing files are hash checked.

@AlienXAXS
Copy link
Contributor

AlienXAXS commented Jan 20, 2018

This works with #22 when the user cancels the download and starts it again later - however an extra dialog perhaps upon pressing Cancel to state "Are you sure?" and "You can resume this download later" might be useful to the end user.

@JAJames
Copy link
Contributor Author

JAJames commented Feb 16, 2018

With those changes in place, I'll rephrase this to focus on resolving the bug where resumed download files are checked and accounted for in the download phase rather than the verification phase.

@JAJames JAJames added bug Something isn't working and removed Required for 1.0 labels Feb 16, 2018
@JAJames JAJames changed the title Allow download resuming Download progress displayed higher than actual when resuming Feb 16, 2018
@JAJames JAJames changed the title Download progress displayed higher than actual when resuming Download speed incorrect when resuming downloads Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Normal Priority
Projects
None yet
Development

No branches or pull requests

2 participants