Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to flow routing API changes in libtopotoolbox #146

Closed
wkearn opened this issue Feb 10, 2025 · 0 comments · Fixed by #147
Closed

Adapt to flow routing API changes in libtopotoolbox #146

wkearn opened this issue Feb 10, 2025 · 0 comments · Fixed by #147
Assignees

Comments

@wkearn
Copy link
Contributor

wkearn commented Feb 10, 2025

TopoToolbox/libtopotoolbox#167 introduced some changes to the flow routing API that will break things here. The main change is to flow_routing_targets, which became flow_routing_d8_edgelist and now accepts an additional parameter. Renaming and fixing this interface is fairly straightforward, but we also need to distinguish between the topologically sorted list of nodes and the source vertices for the edge list on the Python side of things. The node list contains every node in the FlowObject, which is every node in the DEM. The edge list now only contains valid edges: there are no placeholder edges from sinks/outlets to the fictitious -1 node. Functions like drainagebasins and flow_accumulation now expect the edge list rather than the topologically sorted list of nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant