Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve security #2

Open
vollstock opened this issue Jun 25, 2018 · 1 comment
Open

Improve security #2

vollstock opened this issue Jun 25, 2018 · 1 comment
Labels
design enhancement New feature or request help wanted Extra attention is needed

Comments

@vollstock
Copy link
Contributor

The settings server should be secure. Being a network service, it should take some measures to secure the system. Especially as it’s is made to tinkering with the core system.

This however is not an easy task.

First we need to come up with a good concept of what should be protected and how.

Privileges

Right now, the service runs as root. I don’t feel very comfortable doing that but sometimes it needs root privilges to do it’s thing, e.g. when changing the user password or hostname. But it’s not that often.

The tooloop user can call some commands using sudo without being asked for a password:

  • /sbin/poweroff
  • /sbin/reboot
  • /sbin/shutdown
  • starting and stopping the VNC server

These should not be a security issue, I think.

REST service vs. Frontend

The settings server is split in two layers. The frontend (HTML and Javascript) and the backend (Flask / python). Everything we do in the browser simply calls the backend’s REST service.

So whenever when thinking about hardening the settings server, we need to take that into account.

@vollstock vollstock added enhancement New feature or request question Further information is requested design labels Jun 25, 2018
@vollstock
Copy link
Contributor Author

So here is my own proposal of things to decide and do:

  • Move all (REST calls and frontend HTML) communication from HTTP to HTTPS
  • Decide on and implement API security
  • Research whether we need to differentiate between the system user and the API user or in general whether we need actualy system roles.

@vollstock vollstock added help wanted Extra attention is needed and removed question Further information is requested labels Jul 2, 2018
@vollstock vollstock transferred this issue from Tooloop/Tooloop-Settings-Server May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant