Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onion_announce.c cleanup and refactor #2165

Open
JFreegman opened this issue Mar 20, 2022 · 0 comments
Open

onion_announce.c cleanup and refactor #2165

JFreegman opened this issue Mar 20, 2022 · 0 comments
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. P3 Low priority
Milestone
v0.2.x

Comments

@JFreegman
Copy link
Member

JFreegman commented Mar 20, 2022 •
edited
Loading

There's a lot of stuff in onion_announce.c that should be refactored and cleaned up, including using constants as packet type identifiers, and callbacks returning ints instead of bools. For more specific examples, refer to the comments @sudden6 left on #2164
@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Mar 20, 2022
@JFreegman JFreegman added this to the v0.2.19 milestone Mar 20, 2022
@iphydf iphydf added the P3 Low priority label Mar 26, 2022
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Apr 18, 2022
@iphydf iphydf modified the milestones: v0.2.20, v0.2.21 Nov 6, 2024
@iphydf iphydf modified the milestones: v0.2.21, v0.2.x Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. P3 Low priority
Milestone
v0.2.x
Development

No branches or pull requests
2 participants
@JFreegman @iphydf