Skip to content

Commit 66c9c6d

Browse files
committed
Specify allow_os_execution true on CEF 135+
The crash bag is fixed on CEF135. chromiumembedded/cef#3851
1 parent e89329a commit 66c9c6d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

client_handler.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -1913,14 +1913,13 @@ bool ClientHandler::OnSelectClientCertificate(
19131913

19141914
void ClientHandler::OnProtocolExecution(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefRequest> request, bool& allow_os_execution)
19151915
{
1916-
// Using CefBrowser->StopLoad() with allow_os_execution = true causes a crash on CEF128+.
1916+
// Using CefBrowser->StopLoad() with allow_os_execution = true causes a crash on CEF128 - 134.
19171917
// https://github.com/chromiumembedded/cef/issues/3851
19181918
//
19191919
// In order to avoid the crash, specifying allow_os_execution = false on CEF128+, but
19201920
// this blocks to execute applications installed in OS. E.g. Zoom application for Windows.
1921-
//
1922-
// We should specify allow_os_execution = true after the bug on CEF128+ is fixed.
1923-
#if CHROME_VERSION_MAJOR >= 128
1921+
1922+
#if CHROME_VERSION_MAJOR >= 128 && CHROME_VERSION_MAJOR < 135
19241923
allow_os_execution = false;
19251924
#else
19261925
allow_os_execution = true;

0 commit comments

Comments
 (0)