fix(android): remove white stripes appearing after switching from fullscreen #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofMoch
approved these changes
Jul 17, 2024
freeboub
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When switching from fullscreen on Android white stripes appear over and under the
<Video/>component as mentioned in the issue #3926. Thanks to amazing @LiuBergaria we now have a fix for this.Motivation
Closes #3926
In order not to make users to patch the package and use it seamlessly instead, I want the fix proposed to be included in the package's code.
Changes
window.getDecorView().getFitsSystemWindows()Test plan