China Tank Battlemaster with Autoloader upgrade deals less damage per shell than without upgrade

[xezon]

China Tank Battlemaster with Autoloader upgrade deals less damage per shell than without upgrade.

Raised by Stubbjax here: #1704

BattleMasterTankGun deals 1×60 damage per 60 frames and Tank_BattleMasterTankGun deals 3×40 (120) damage per 92 (16 + 16 + 60) frames. Note that the 500ms delay between each shot in the clip translates to 533.33ms and thus 16 frames.

Upgrade	Damage	Fire Rate	DPS
None	60	2000ms	30
Nationalism	60	1600ms	37.5
Autoloader	120	3067ms	39.13
Both	120	2400ms	50

It would be nice if individual Tank Battlemaster shells would always deal same damage. Because that way damage is way more plausible than if 3 shells deal somehow less damage than expected, even if overall damage output over time is increased compared to the regular 1 shell firing.

[xezon]

Proposal 1

Raise Autoloader damage per shell to 60 and adjust DelayBetweenShots and ClipReloadTime accordingly to preserve original DPS.

Weapon	PrimaryDamage	Delay	ClipSize	ClipReloadTime	DPS
Original BattleMasterTankGun	60	2000	0	0	30
Original Tank_BattleMasterTankGun	40	500	3	2000	39.13
Patched Tank_BattleMasterTankGun	60	650	3	3250	39.27

Original - PrimaryDamage 40

generals.2023-02-14.20-43-49-62.mp4

Change - PrimaryDamage 60

generals.2023-02-14.20-38-47-63.mp4

[xezon]

Maybe not a good idea. Not sure. It creates small discrepancies of DPS with various other weapon bonuses, so likely will not be possible to retain identical DPS.

[MTKing4]

This was intentional by design, there's no reason to change it

There's data to back this up in reality as well, tanks that behave exactly the same, shooting multiple rounds in a matter of seconds, but those shells tend to be smaller, therefore less damage, so it makes sense, don't change it

Examples:

HSTV-L Experimental US Light Tank:

And Swedish S-tank Stridsvagn 103: