China Nationalism (and Patriotism) apply fire rate bonus to units regardless of Horde bonus

[xezon]

• Related to Fix: Describe China Nationalism and Patriotism upgrade bonuses more accurately GeneralsGamePatch#1624
• Related to Nationalism and Patriotism Work Without Horde GeneralsGamePatch#810

China Nationalism (and Patriotism) apply fire rate bonus to units regardless of Horde bonus.

[xezon]

Do we care for it? Does it need to be fixed in Thyme?

[MTKing4]

While it makes sense because the upgrade is visible only when you have an active horde bonus as the decal changes after the upgrade , it would change the game too much to fix it.

[Stubbjax]

I think it should be fixed due to it being the intended original design and it's a more interesting paradigm than just a flat +25% fire rate.

It would directly nerf Infantry General who starts with the +25% fire rate from having Nationalism pre-researched, but otherwise I don't think the impact would be too great. Infantry General can do with a nerf anyway.

[xezon]

Fixing this and issue #174 may require us to revisit Horde conditions.