Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-version parameter being passed to Microsoft Graph #13

Closed
jonty-comp opened this issue Mar 1, 2016 · 3 comments
Closed

api-version parameter being passed to Microsoft Graph #13

jonty-comp opened this issue Mar 1, 2016 · 3 comments
Labels

Comments

@jonty-comp
Copy link
Contributor

Hi,

Thanks for the great library. I've encountered a small issue when making calls to the Microsoft Graph API - see Stack Overflow here. I see you've recently changed part of the request function in #11, but that doesn't seem to have made any difference.

The fix seems fairly simple; to not append the api-version parameter on the MS Graph, (although they shouldn't be spitting out malformed JSON no matter what...) but I didn't want to do it myself via pull request without checking first whether you mind adding a hard-coded check for something like that.

@hajekj
Copy link
Member

hajekj commented Mar 1, 2016

Hello,
I had something similar on mind - but I didn't implement it because it could make people go mad about the hardcoded check, however, since you came with that - I don't mind at all - it anyways seems to be the only easy way! It would be great if you could submit the PR, because I can get to doing this myself no sooner than during the weekend.

Thanks a lot,
Jan

@hajekj hajekj added the bug label Mar 1, 2016
@hajekj hajekj closed this as completed in a6de344 Mar 1, 2016
@hajekj
Copy link
Member

hajekj commented Mar 1, 2016

Thanks a lot for the pull request, it has now been merged. I will be releasing the updated version as 1.1.1. If you have any other ideas, issues or features, feel free to contribute again!

@jonty-comp
Copy link
Contributor Author

Thanks for the quick response. It's worth noting for anyone who ends up on this page that Microsoft have rolled out a bugfix to invalidate requests with the api-version parameter (see here) so if you're using Microsoft Graph you'll have to update to v1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants