You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the great library. I've encountered a small issue when making calls to the Microsoft Graph API - see Stack Overflow here. I see you've recently changed part of the request function in #11, but that doesn't seem to have made any difference.
The fix seems fairly simple; to not append the api-version parameter on the MS Graph, (although they shouldn't be spitting out malformed JSON no matter what...) but I didn't want to do it myself via pull request without checking first whether you mind adding a hard-coded check for something like that.
The text was updated successfully, but these errors were encountered:
Hello,
I had something similar on mind - but I didn't implement it because it could make people go mad about the hardcoded check, however, since you came with that - I don't mind at all - it anyways seems to be the only easy way! It would be great if you could submit the PR, because I can get to doing this myself no sooner than during the weekend.
Thanks a lot for the pull request, it has now been merged. I will be releasing the updated version as 1.1.1. If you have any other ideas, issues or features, feel free to contribute again!
Thanks for the quick response. It's worth noting for anyone who ends up on this page that Microsoft have rolled out a bugfix to invalidate requests with the api-version parameter (see here) so if you're using Microsoft Graph you'll have to update to v1.1.1.
Hi,
Thanks for the great library. I've encountered a small issue when making calls to the Microsoft Graph API - see Stack Overflow here. I see you've recently changed part of the request function in #11, but that doesn't seem to have made any difference.
The fix seems fairly simple; to not append the api-version parameter on the MS Graph, (although they shouldn't be spitting out malformed JSON no matter what...) but I didn't want to do it myself via pull request without checking first whether you mind adding a hard-coded check for something like that.
The text was updated successfully, but these errors were encountered: