Skip to content

Commit 06f28ad

Browse files
committed
#248 Take into account the new case metrics format in dblist table
1 parent a891111 commit 06f28ad

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

ui/app/scripts/controllers/admin/AdminMetricsCtrl.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
ListSrv.query({
1616
'listId': 'case_metrics'
1717
}, {}, function(response) {
18-
19-
$scope.metrics = _.values(response).filter(_.isString).map(function(item) {
20-
return JSON.parse(item);
18+
$scope.metrics = _.map(response.toJSON(), function(value, metricId) {
19+
value.id = metricId;
20+
return value;
2121
});
2222

2323
}, function(response) {
@@ -30,7 +30,7 @@
3030
ListSrv.save({
3131
'listId': 'case_metrics'
3232
}, {
33-
'value': JSON.stringify($scope.metric)
33+
'value': $scope.metric
3434
}, function() {
3535
$scope.initMetrics();
3636

ui/app/scripts/services/MetricsCacheSrv.js

+6-7
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,13 @@
2727

2828
if(metrics === null) {
2929
resource.query({listId: 'case_metrics'}, {}, function(response) {
30-
metrics = {};
31-
var data = _.values(response).filter(_.isString).map(function(item) {
32-
return JSON.parse(item);
33-
});
30+
var json = response.toJSON();
3431

35-
_.each(data, function(m){
36-
metrics[m.name] = m;
37-
});
32+
metrics = {};
33+
34+
_.each(_.values(json), function(metric) {
35+
metrics[metric.name] = metric;
36+
})
3837

3938
deferred.resolve(metrics);
4039
}, function(response) {

ui/app/views/partials/case/details/metrics.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ <h4 class="vpad10 text-primary">
1818
</div>
1919

2020
<dl class="dl-horizontal clear" ng-repeat="(k,v) in caze.metrics">
21-
<dt class="pull-left" uib-tooltip="{{metricsCache[k].description}}">{{metricsCache[k].title}}</dt>
21+
<dt class="pull-left" uib-tooltip="{{metricsCache[k].description}}">{{metricsCache[k].title || k}}</dt>
2222
<dd>
2323
<updatable-simple-text input-type="number" on-update="updateField('metrics.' + k, newValue)" value="caze.metrics[k]"></updatable-simple-text>
2424
</dd>

0 commit comments

Comments
 (0)