fix(commonpath): commonPath fixed for subdirectories with nonGlobalSt…

…epDefinitions see discussion in #594 closes #594 , closes #593
badeball · Jul 9, 2021 · 2054f3d · 2054f3d
1 parent 4fb5873
commit 2054f3d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/lib/getStepDefinitionsPaths.js b/lib/getStepDefinitionsPaths.js
@@ -14,7 +14,7 @@ const getStepDefinitionsPaths = (filePath) => {
     let commonPath = config.commonPath || `${stepDefinitionPath()}/common/`;
 
     if (config.commonPath) {
-      commonPath = path.resolve(appRoot, commonPath);
+      commonPath = `${path.resolve(appRoot, commonPath)}/`;
     }
 
     if (config.nonGlobalStepBaseDir) {

diff --git a/lib/getStepDefinitionsPaths.test.js b/lib/getStepDefinitionsPaths.test.js
@@ -1,3 +1,4 @@
+// file.only
 /* eslint-disable global-require */
 jest.mock("./stepDefinitionPath.js", () => () => "stepDefinitionPath");
 jest.mock("glob", () => ({
@@ -28,16 +29,7 @@ describe("getStepDefinitionsPaths", () => {
   });
 
   it("should return the common folder defined by the developer", () => {
-    jest.mock("path", () => ({
-      resolve(appRoot, commonPath) {
-        return `./${appRoot}/${commonPath}`;
-      },
-      extname() {
-        return ".js";
-      },
-    }));
-
-    jest.spyOn(process, "cwd").mockImplementation(() => "cwd");
+    jest.spyOn(process, "cwd").mockImplementation(() => "/cwd/");
 
     getConfig.mockReturnValue({
       nonGlobalStepDefinitions: true,
@@ -47,7 +39,7 @@ describe("getStepDefinitionsPaths", () => {
     const { getStepDefinitionsPaths } = require("./getStepDefinitionsPaths");
 
     const actual = getStepDefinitionsPaths("/path");
-    const expected = "./cwd/myPath/**/*.+(js|ts|tsx)";
+    const expected = "/cwd/myPath/**/*.+(js|ts|tsx)";
     expect(actual).to.include(expected);
   });
   it("should return the default non global step definition pattern", () => {