Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect convertion of global events to vocals phrases #88

Open
TheBoxyBear opened this issue Sep 8, 2024 · 0 comments
Open

Incorrect convertion of global events to vocals phrases #88

TheBoxyBear opened this issue Sep 8, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
Release

Comments

@TheBoxyBear
Copy link
Owner

Severity: Major

When converting from global events to phrases, the number of phrases appears to be correct, but each one contains the lyrics of the entire song.

Steps to reproduce

  1. Read a chart file with the GlobalEvents component enabled
  2. Call PhraseExtension.GetLyrics with the gloval event list
  3. Print Phrase.DisplayedText for each resulting phrase
  4. See error

Expected behavior
Lyrics are displayed with one phrase per line

Actual behavior
The entire song's lyrics is displayed multiple times across several lines

Chart link
https://drive.google.com/file/d/1vYv5v8gsahGpZO3lz70W5YjJeTkzzXKN/view?usp=drive_link

Screenshot (Optional)
image
@TheBoxyBear TheBoxyBear added the bug Something isn't working label Sep 8, 2024
@TheBoxyBear TheBoxyBear added this to the Release milestone Sep 8, 2024
@TheBoxyBear TheBoxyBear added good first issue Good for newcomers and removed good first issue Good for newcomers labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release
Development

No branches or pull requests
1 participant
@TheBoxyBear